feat: Emissions alignment with expected schedule #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roisindowling
approved these changes
Sep 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
===========================================
- Coverage 94.50% 20.71% -73.80%
===========================================
Files 39 53 +14
Lines 2601 3911 +1310
Branches 561 574 +13
===========================================
- Hits 2458 810 -1648
- Misses 142 3101 +2959
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a typo in the configuration of the emissions schedule caused by setting the X allocations decay period to
912instead of the intended12. As a result, a correction is made to reduce the B3TR distribution by200,000in round14to offset the excess200,000 B3TRdistributed in round13.Changes Made:
200,000 B3TRin round 14.Testing:
Testing has been conducted using the
"Should be able to perform all cycles till reaching B3TR supply cap with Emissions alignment"test case. This confirms that rounds 14 and 15 are processed correctly, and the emissions schedule aligns with the expected values.